This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rG9e83d0bcdfe8: [clangd] Mention when CXXThis is implicit in
exposed AST. (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D91868?vs=3
kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/DumpAST.cpp:233
return CCO->getConstructor()->getNameAsString();
+if (const auto *CTE = dyn_cast(S)) {
+ bool Con
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/DumpAST.cpp:233
return CCO->getConstructor()->getNameAsString();
+if (const auto *CTE = dyn_cast(S)) {
+ bool Const = CTE->getType()->getPointeeType().isLocalConstQualified();
k
kadircet added a comment.
This looks like an improvement to me as well, thanks!
Comment at: clang-tools-extra/clangd/DumpAST.cpp:233
return CCO->getConstructor()->getNameAsString();
+if (const auto *CTE = dyn_cast(S)) {
+ bool Const = CTE->getType()->getPointeeT
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman.
Herald added a project: clang.
sammccall requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Seeing an implicit this in the AST is pre
