[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

nickdesaulniers added inline comments. Comment at: clang-tools-extra/clang-tidy/linuxkernel/ExtraSemiCheck.h:37 + std::vector SuspectMacros; + enum ExtraSemiFixerKind FixerKind; + const std::string ExtraSemiFixerKindName; aaron.ballman wrote: > You can drop th

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/linuxkernel/ExtraSemiCheck.cpp:49 + +void ExtraSemiCheck::registerMatchers(MatchFinder *Finder) { + if (FixerKind == ESFK_Switch) { Something that's not for you to solve, but for us to

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

trixirt added a comment. How this is run in the kernel is a wip so adding it to the commit log is not very helpful. Here is the lkml rfc https://lkml.org/lkml/2020/11/21/190 This calling in the kernel needs needs to change because of the refactor. The auto suggestions fail to build, so they are

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

trixirt updated this revision to Diff 309270. trixirt added a comment. move enum Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91789/new/ https://reviews.llvm.org/D91789 Files: clang-tools-extra/clang-tidy/linuxkernel/CMakeLists.txt clang-tool

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

nickdesaulniers added a comment. Hi @trixirt , thanks for the follow up. I think the lint feedback about qualifying `auto` with pointers where applicable would be nice to have. Please make those suggested changes. Should https://reviews.llvm.org/D90180 be abandoned in favor of this patch? Wou

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

trixirt updated this revision to Diff 308963. trixirt added a comment. address precheckin issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91789/new/ https://reviews.llvm.org/D91789 Files: clang-tools-extra/clang-tidy/linuxkernel/CMakeLists.

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

trixirt updated this revision to Diff 308214. trixirt edited the summary of this revision. trixirt added a comment. Refactor to combine switch and trailing macro into one fixer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91789/new/ https://review

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

trixirt updated this revision to Diff 307602. trixirt added a comment. Addresses issues before refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91789/new/ https://reviews.llvm.org/D91789 Files: clang-tools-extra/clang-tidy/linuxkernel/

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. The request in D90180 was to not add a check for each kind of problematic semicolon situation but to instead make a single check that

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/linuxkernel/LinuxKernelTidyModule.cpp:25 "linuxkernel-must-check-errs"); CheckFactories.registerCheck("linuxkernel-switch-semi"); } This check hasn't landed, can you please

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/linuxkernel/MacroTrailingSemiCheck.cpp:15 + +#include + Any reason for including the c standard header? Comment at: clang-tools-extra/clang-tidy/linuxkernel/MacroTraili

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/linuxkernel/MacroTrailingSemiCheck.cpp:31 +const MacroDirective *MD) override { +auto *MI = MD->getMacroInfo(); + Please don't use auto when type is not spelle

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

trixirt created this revision. trixirt added reviewers: nickdesaulniers, alexfh, hokein, aaron.ballman. trixirt added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. trixirt requested review of this revision. Cleaning up -Wextr