[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

ABataev added a comment. Restore original formatting in test cases that were not directly affected by the patch. Also, I would start with a single kind of expression rather than trying to cover as many kinds of expressions as possible. It makes it easier to understand and to review it. =

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

jacobdweightman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91373/new/ https://reviews.llvm.org/D91373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

jacobdweightman updated this revision to Diff 309056. jacobdweightman added a comment. I separated the handling of `ConditionalOperator`s and `BinaryConditionalOperator`s in order to eliminate handling of `OpaqueValueExpression`s in general, and asserted that the OVE's `SourceExpr` is not null.

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

jacobdweightman added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16869 +// Allow results of method calls to be mapped. +if (isa(ME->getMemberDecl())) { + RelevantExpr = ME; ABataev wrote: > I don't think it should always return `true`

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16869 +// Allow results of method calls to be mapped. +if (isa(ME->getMemberDecl())) { + RelevantExpr = ME; I don't think it should always return `true`. What about `map(s.foo)`

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

ABataev added a comment. In D91373#2408175 , @jacobdweightman wrote: > Ping 1. Provide full diff, see https://www.llvm.org/docs/Phabricator.html for the guidance. 2. Need some more test with ast printing and codegen. 3. Would be good if you could run

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

jacobdweightman added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91373/new/ https://reviews.llvm.org/D91373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

jacobdweightman added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:17141 + Visit(ACO->getTrueExpr()->IgnoreParenImpCasts()) || + Visit(ACO->getFalseExpr()->IgnoreParenImpCasts()); + } It looks like this short-circuits and the fa

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

jacobdweightman created this revision. jacobdweightman added a reviewer: ABataev. jacobdweightman added a project: OpenMP. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. jacobdweightman requested review of this revision. Herald added a reviewer: jdoerfert. H