[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire added a comment. In D91302#2468665 , @thakis wrote: > Looks like this breaks tests on windows: > http://45.33.8.238/win/30322/step_8.txt > > Ptal, and revert for now if it takes a while to fix. (In particular, prefer > reverting over disabling t

[PATCH] D91302: Handle template instantiations better in clang-tidy check

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/30322/step_8.txt Ptal, and revert for now if it takes a while to fix. (In particular, prefer reverting over disabling the test on win.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D91302: Handle template instantiations better in clang-tidy check

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5311d731e1b: [clang-tidy] Handle template instantiations in conta

[PATCH] D91302: Handle template instantiations better in clang-tidy check

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91302/new/ https://reviews.llvm.org/D91302 ___ cfe-commits mailing list cfe-commit

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire updated this revision to Diff 313385. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91302/new/ https://reviews.llvm.org/D91302 Files: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire updated this revision to Diff 313361. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91302/new/ https://reviews.llvm.org/D91302 Files: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire updated this revision to Diff 313360. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91302/new/ https://reviews.llvm.org/D91302 Files: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire updated this revision to Diff 313354. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91302/new/ https://reviews.llvm.org/D91302 Files: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

[PATCH] D91302: Handle template instantiations better in clang-tidy check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:56 +AST_MATCHER(Expr, usedInBooleanContext) { + std::string exprName = "__booleanContextExpr"; + auto result = Comment at:

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire marked 2 inline comments as done. steveire added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:26-28 + // The first argument of an overloaded member operator is the implicit object + // argument of the method which s

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire updated this revision to Diff 313346. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91302/new/ https://reviews.llvm.org/D91302 Files: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

[PATCH] D91302: Handle template instantiations better in clang-tidy check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:26-28 + // The first argument of an overloaded member operator is the implicit object + // argument of the method which should not be matched against a paramet

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire updated this revision to Diff 312071. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91302/new/ https://reviews.llvm.org/D91302 Files: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:20 +namespace ast_matchers { +AST_POLYMORPHIC_MATCHER_P2(hasAnyArgumentWithParam, + AST_POLYMORPHIC_SUPPORTED_TYPES(CallExpr, --

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire updated this revision to Diff 312063. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91302/new/ https://reviews.llvm.org/D91302 Files: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

[PATCH] D91302: Handle template instantiations better in clang-tidy check

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Please fix the typo that results in a compile error. Comment at: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:107 + h

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire created this revision. steveire added a reviewer: alexfh. Herald added a project: clang. Herald added a subscriber: cfe-commits. steveire requested review of this revision. readability-container-size-empty currently modifies source code based on AST nodes in template instantiations, which