[PATCH] D91229: [FileCheck] Flip -allow-unused-prefixes to false by default

2020-11-11 Thread Mircea Trofin via Phabricator via cfe-commits
mtrofin added a comment. In D91229#2389141 , @dblaikie wrote: >> because FileCheck won't accept more than one occurrence of >> --allow-unused-prefixes > > Perhaps this is a fixable issue? I think I was able to circumvent it in D91275

[PATCH] D91229: [FileCheck] Flip -allow-unused-prefixes to false by default

2020-11-11 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. > because FileCheck won't accept more than one occurrence of > --allow-unused-prefixes Perhaps this is a fixable issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91229/new/ https://reviews.llvm.org/D91229 __

[PATCH] D91229: [FileCheck] Flip -allow-unused-prefixes to false by default

2020-11-11 Thread Mircea Trofin via Phabricator via cfe-commits
mtrofin added a comment. In D91229#2387923 , @jhenderson wrote: > Maybe one way to do this is to do what @RKSimon suggests in the D90281 > , and to enable it on a per-directory basis > using lit.local.cfg. That would pote

[PATCH] D91229: [FileCheck] Flip -allow-unused-prefixes to false by default

2020-11-11 Thread Mircea Trofin via Phabricator via cfe-commits
mtrofin created this revision. mtrofin added a reviewer: jhenderson. Herald added subscribers: llvm-commits, cfe-commits, frasercrmck, nikic, okura, jdoerfert, kuter, kerbowa, luismarques, apazos, sameer.abuasal, pzheng, pengfei, s.egerton, lenary, dmgreen, Jim, asbirlea, thopre, mstorsjo, jocewe

[PATCH] D91229: [FileCheck] Flip -allow-unused-prefixes to false by default

2020-11-11 Thread Mircea Trofin via Phabricator via cfe-commits
mtrofin added a comment. FYI - I realize the change is enormous. I don't necessarily mean to land it as-is, we can chunk it by directories and iteratively update this as those land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91229/new/ https://

[PATCH] D91229: [FileCheck] Flip -allow-unused-prefixes to false by default

2020-11-11 Thread James Henderson via Phabricator via cfe-commits
jhenderson added a subscriber: RKSimon. jhenderson added a comment. Maybe one way to do this is to do what @RKSimon suggests in the D90281 , and to enable it on a per-directory basis using lit.local.cfg. That would potentially require changing the "0 or 1" occur