[PATCH] D91222: [WebAssembly] Remove wasm-specific TLS builtins

2020-11-10 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 added a comment. Nope I was wrong, emscripten does use these. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91222/new/ https://reviews.llvm.org/D91222 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D91222: [WebAssembly] Remove wasm-specific TLS builtins

2020-11-10 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 added a comment. I don't think so but I will double check. I'm in the middle of some TLS rethinking so I'll leave this open for now pending any changes to our TLS ABI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91222/new/ https://review

[PATCH] D91222: [WebAssembly] Remove wasm-specific TLS builtins

2020-11-10 Thread Thomas Lively via Phabricator via cfe-commits
tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Excellent, thanks. I hope I'm not forgetting any good reason we added these. Emscripten doesn't use them in its pthreads runtime, right? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D91222: [WebAssembly] Remove wasm-specific TLS builtins

2020-11-10 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 created this revision. Herald added subscribers: llvm-commits, cfe-commits, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, dschuff. Herald added projects: clang, LLVM. sbc100 requested review of this revision. Herald added a subscriber: aheejin. These builtins don't have any actua