t.p.northover closed this revision.
t.p.northover added a comment.
Thanks Gerolf. Committed:
To github.com:llvm/llvm-project.git
ae9d96a656a1..152df3add156 master -> master
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91147/new/
https://reviews.llvm.org/D91147
___
Gerolf accepted this revision.
Gerolf added a comment.
This revision is now accepted and ready to land.
LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91147/new/
https://reviews.llvm.org/D91147
___
cfe-commits mailing list
cfe-commits@li
t.p.northover updated this revision to Diff 305064.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91147/new/
https://reviews.llvm.org/D91147
Files:
clang/lib/Driver/ToolChain.cpp
clang/test/Driver/frame-pointer-elim.c
llvm/include/llvm/ADT/Triple.h
llvm/lib/BinaryFormat/MachO.cpp
t.p.northover added inline comments.
Comment at: clang/lib/Driver/ToolChain.cpp:1066
if (getTriple().getArch() == llvm::Triple::x86_64 ||
- getTriple().isAArch64() || getTriple().isRISCV())
+ (getTriple().isAArch64() && getTriple().isArch64Bit()) ||
+ getTriple(
dexonsmith added inline comments.
Comment at: clang/lib/Driver/ToolChain.cpp:1066
if (getTriple().getArch() == llvm::Triple::x86_64 ||
- getTriple().isAArch64() || getTriple().isRISCV())
+ (getTriple().isAArch64() && getTriple().isArch64Bit()) ||
+ getTriple().i
t.p.northover created this revision.
Herald added subscribers: dexonsmith, danielkiss, s.egerton, simoncook,
hiraditya, kristof.beyls, mcrosier.
Herald added a project: LLVM.
t.p.northover requested review of this revision.
We want `arm64_32` to omit leaf frame pointers. At the moment this is
pr