This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG91ce6fb5a65f: [clangd] Abort rename when given the same name
(authored by kbobyrev).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTIO
kbobyrev updated this revision to Diff 304434.
kbobyrev added a comment.
Add a comment to the test to make it more explicit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91134/new/
https://reviews.llvm.org/D91134
Files:
clang-tools-extra/clangd
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:780
+void func() {
+ int V^ar;
+}
Add a comment or rename `Var` =
kbobyrev marked an inline comment as not done.
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:218
+case ReasonToReject::SameName:
+ return "new name should differ from the old name";
}
hokein wrote:
> sammcc
kbobyrev updated this revision to Diff 304423.
kbobyrev marked an inline comment as done.
kbobyrev added a comment.
- Change error message to description rather than suggestion.
- Move test to more appropriate location.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://r
hokein added inline comments.
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:218
+case ReasonToReject::SameName:
+ return "new name should differ from the old name";
}
sammccall wrote:
> hokein wrote:
> > returning an error seems to be an
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:218
+case ReasonToReject::SameName:
+ return "new name should differ from the old name";
}
hokein wrote:
> returning an error seems to be an interesting idea,
hokein added inline comments.
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:218
+case ReasonToReject::SameName:
+ return "new name should differ from the old name";
}
returning an error seems to be an interesting idea, thinking more about
kbobyrev created this revision.
kbobyrev added a reviewer: hokein.
Herald added subscribers: cfe-commits, usaxena95, arphaman.
Herald added a project: clang.
kbobyrev requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
When user wants to rename the symbol to the sa
