This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGfef242c32e83: [clangd] Fix locateMacroAt() for macro
definition outside preamble (authored by nridge).
Repository:
rG LLVM Github Monorepo
CHANGE
nridge updated this revision to Diff 311472.
nridge marked 3 inline comments as done.
nridge added a comment.
Address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91025/new/
https://reviews.llvm.org/D91025
Files:
clang-tools-ext
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Nice catch! As always, sorry about the delay.
Comment at: clang-tools-extra/clangd/SourceCode.cpp:987
+ FileID FID = SM.getFileID(Loc);
+ auto JustAfterToken =
+
nridge added a comment.
Review ping :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91025/new/
https://reviews.llvm.org/D91025
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.
nridge added a reviewer: sammccall.
nridge added a comment.
Sam, you're my go-to reviewer for "tricky macro stuff", but feel free to hand
off if you prefer :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91025/new/
https://reviews.llvm.org/D91025
nridge created this revision.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman.
Herald added a project: clang.
nridge requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Fixes https://github.com/clangd/clangd/issues/577
Repository:
rG LLVM G
