[PATCH] D90832: [clang-tidy] Extend IdentifierNamingCheck per file config

2020-11-05 Thread Nathan James via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b9b90a1914f: [clang-tidy] Extend IdentifierNamingCheck per file config (authored by njames93). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D90832: [clang-tidy] Extend IdentifierNamingCheck per file config

2020-11-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some tiny nits! Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:172 SmallString<64> StyleString; + auto Styl

[PATCH] D90832: [clang-tidy] Extend IdentifierNamingCheck per file config

2020-11-05 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 303198. njames93 added a comment. Herald added a subscriber: aheejin. Removed unnecessary formatting changes Added test cases. With the test cases I removed some cases that actually were never tested due to the order in which clang-tidy handles applying con

[PATCH] D90832: [clang-tidy] Extend IdentifierNamingCheck per file config

2020-11-05 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. Didn't mean for there to be any formatting changes. I'll remove those later too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90832/new/ https://reviews.llvm.org/D90832 ___ cfe-

[PATCH] D90832: [clang-tidy] Extend IdentifierNamingCheck per file config

2020-11-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D90832#2376009 , @njames93 wrote: > In D90832#2375934 , @aaron.ballman > wrote: > >> Is there a way to test this functionality out? > > There's already tests for loading the indivi

[PATCH] D90832: [clang-tidy] Extend IdentifierNamingCheck per file config

2020-11-05 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. In D90832#2375934 , @aaron.ballman wrote: > Is there a way to test this functionality out? There's already tests for loading the individual styles from other files, I'm sure I could extend that Repository: rG LLVM Github Mo

[PATCH] D90832: [clang-tidy] Extend IdentifierNamingCheck per file config

2020-11-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Is there a way to test this functionality out? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90832/new/ https://reviews.llvm.org/D90832 ___ cfe-commits mailing list cfe-com

[PATCH] D90832: [clang-tidy] Extend IdentifierNamingCheck per file config

2020-11-05 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 requested review of this revision. Add IgnoreMainLikeFunctions to the per file config. This can be extended for ne