Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

2015-09-22 Thread Devin Coughlin via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248336: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0). (authored by dcoughlin). Changed prior to commit: http://reviews.llvm.org/D9040?vs=34583&id=35432#toc Repository: rL LLVM ht

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

2015-09-21 Thread Anna Zaks via cfe-commits
zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. See the suggestion for an improved comment. Otherwise, LGTM! Thanks! Anna. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:902 @@ +901,3 @@ +} else { +

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

2015-09-21 Thread Антон Ярцев via cfe-commits
ayartsev added a comment. Ping. http://reviews.llvm.org/D9040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

2015-09-16 Thread Антон Ярцев via cfe-commits
ayartsev added a comment. Ping. http://reviews.llvm.org/D9040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

2015-09-11 Thread Антон Ярцев via cfe-commits
ayartsev updated this revision to Diff 34583. ayartsev added a comment. Updated the patch after r246978. Please review! http://reviews.llvm.org/D9040 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/malloc.c Index: test/Analysis/malloc.c ==

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

2015-09-07 Thread Антон Ярцев via cfe-commits
ayartsev added a comment. Ping. http://reviews.llvm.org/D9040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

2015-09-01 Thread Антон Ярцев via cfe-commits
ayartsev added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:523 @@ -510,2 +522,3 @@ REGISTER_MAP_WITH_PROGRAMSTATE(ReallocPairs, SymbolRef, ReallocPair) +REGISTER_MAP_WITH_PROGRAMSTATE(ReallocSizeZeroFlag, SymbolRef, ReallocSizeZero) --

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

2015-09-01 Thread Антон Ярцев via cfe-commits
ayartsev updated this revision to Diff 33740. http://reviews.llvm.org/D9040 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/malloc.c Index: test/Analysis/malloc.c === --- test/Analysis/malloc.c +++ test/Analys

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

2015-09-01 Thread Anna Zaks via cfe-commits
zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:523 @@ -510,2 +522,3 @@ REGISTER_MAP_WITH_PROGRAMSTATE(ReallocPairs, SymbolRef, ReallocPair) +REGISTER_MAP_WITH_PROGRAMSTATE(ReallocSizeZeroFlag, SymbolRef, ReallocSizeZero) -

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

2015-09-01 Thread Антон Ярцев via cfe-commits
ayartsev added a comment. Ping http://reviews.llvm.org/D9040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

2015-08-25 Thread Антон Ярцев via cfe-commits
ayartsev added a comment. Please review! Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:158 @@ +157,3 @@ +/// zero-allocated memory returned by 'realloc(ptr, 0)'. +struct ReallocSizeZero { + void Profile(llvm::FoldingSetNodeID &ID) const { zaks.anna

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

2015-08-25 Thread Антон Ярцев via cfe-commits
ayartsev updated this revision to Diff 33134. http://reviews.llvm.org/D9040 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/malloc.c Index: test/Analysis/malloc.c === --- test/Analysis/malloc.c +++ test/Analys