[PATCH] D90123: [Sema] Improve notes for value category mismatch in overloading

aaronpuchert marked an inline comment as done. aaronpuchert added a comment. Fixed the spelling issue in rGdea31f135ceae6e860e6301f9bb66d3b3adb1357 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D90123: [Sema] Improve notes for value category mismatch in overloading

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f84779674a9: [Sema] Improve notes for value category mismatch in overloading (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHA

[PATCH] D90123: [Sema] Improve notes for value category mismatch in overloading

aaronpuchert added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:4280 "candidate %sub{select_ovl_candidate_kind}0,1,2 not viable: " -"expects an l-value for " +"expects an %select{l-value|r-value}5 for " "%select{%ordinal4 argumen

[PATCH] D90123: [Sema] Improve notes for value category mismatch in overloading

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:4280 "candidate %sub{select_ovl_candidate_kind}0,1,2 not viable: " -"expects an l-value for " +

[PATCH] D90123: [Sema] Improve notes for value category mismatch in overloading

aaronpuchert added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:4927 // Note that the function case is not possible here. -if (DeclType->isRValueReferenceType() && LValRefType) { - // FIXME: This is the wrong BadConversionSequence. The problem is bin

[PATCH] D90123: [Sema] Improve notes for value category mismatch in overloading

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, rsmith. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. aaronpuchert requested review of this revision. When an overloaded member function has a ref-qualifier, like: class X { voi