[PATCH] D89987: [analyzer] [NFC] Rename SymbolRef to SymExprRef

ASDenysPetrov added a comment. @steakhal > Losing **git blame** would have a signifficant impact in deed, however we > always have the option to add the renaming commit to the > `.git-blame-ignore-revs`. Using this git feature I can see no more obstacles to implement the renaming. Moreover LL

[PATCH] D89987: [analyzer] [NFC] Rename SymbolRef to SymExprRef

Szelethus added a comment. In D89987#2350649 , @NoQ wrote: > Honestly i'd rather eliminate `SymExpr` and go with `Symbol` everywhere. It's > an overloaded term but appending "Expr" to it doesn't really make it > significantly less overloaded. Why? I thi

[PATCH] D89987: [analyzer] [NFC] Rename SymbolRef to SymExprRef

NoQ added a comment. Honestly i'd rather eliminate `SymExpr` and go with `Symbol` everywhere. It's an overloaded term but appending "Expr" to it doesn't really make it significantly less overloaded. We're also properly namespaced so there wouldn't be any linking issues with the rest of LLVM. "S

[PATCH] D89987: [analyzer] [NFC] Rename SymbolRef to SymExprRef

steakhal added a comment. In D89987#2349959 , @ASDenysPetrov wrote: > @OikawaKirie > >> Different from ProgramStateRef which is an alias to IntrusiveRefCntPtr, or >> StoreRef which is a wrapper object, an alias to a const SymExpr * makes no >> sense to

[PATCH] D89987: [analyzer] [NFC] Rename SymbolRef to SymExprRef

ASDenysPetrov added a comment. @OikawaKirie > Different from ProgramStateRef which is an alias to IntrusiveRefCntPtr, or > StoreRef which is a wrapper object, an alias to a const SymExpr * makes no > sense to me. Yes. I omit this, because in such case we should go further and rename all those

[PATCH] D89987: [analyzer] [NFC] Rename SymbolRef to SymExprRef

steakhal added a comment. @ASDenysPetrov Please grep for the `SymbolRef` and rename the other symbols/comments as well, especially the compound names. In D89987#2348935 , @OikawaKirie wrote: > Since `SymbolRef` is just a `const SymExpr *` in the current

[PATCH] D89987: [analyzer] [NFC] Rename SymbolRef to SymExprRef

OikawaKirie added a comment. Since `SymbolRef` is just a `const SymExpr *` in the current codebase, I'd prefer using `const SymExpr *` directly, just like how `MemRegion` is used, which would be clearer than both `SymbolRef` and `SymExprRef` as far as I am thinking. Different from `ProgramStat