This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG19db870a0dd1: [clangd] Drop template argument lists from
completions followed by < (authored by kbobyrev).
Repository:
rG LLVM Github Monorepo
CH
kbobyrev updated this revision to Diff 324593.
kbobyrev marked 4 inline comments as done.
kbobyrev added a comment.
Address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89870/new/
https://reviews.llvm.org/D89870
Files:
clang-too
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:474
+//
+// fu^(42) -> function(42);
+if (Snippet->front() == '<') {
-
kbobyrev updated this revision to Diff 324386.
kbobyrev marked 4 inline comments as done.
kbobyrev added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89870/new/
https://reviews.llvm.org/D89870
Files:
clang-to
kadircet added a comment.
(sorry for forgetting about this)
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:450
+if (Snippet->front() == '<')
+ return Snippet->substr(0, Snippet->find('('));
+return "";
what if we have `(` in the
kbobyrev added a comment.
@sammccall Ping, this is a real patch :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89870/new/
https://reviews.llvm.org/D89870
___
cfe-commits mailing list
cfe-commits@lists.
kbobyrev created this revision.
kbobyrev added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman.
Herald added a project: clang.
kbobyrev requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Now, given `template foo() {}` w
