[PATCH] D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API

tianshilei1992 added a comment. In D89802#2402886 , @jhuber6 wrote: > Rebasing. Sorry I got it confused, @tianshilei1992 you said you had a crash > using this patch, I haven't encountered any errors on my machine. Could you > verify that this doesn't cau

[PATCH] D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API

tianshilei1992 added a comment. In D89802#2359537 , @jhuber6 wrote: > In D89802#2359504 , @tianshilei1992 > wrote: > >> This patch caused segment fault in D90099 >> where the map

[PATCH] D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API

jhuber6 added a comment. In D89802#2359504 , @tianshilei1992 wrote: > This patch caused segment fault in D90099 > where the map variable info pointer is `nullptr` but it is deferenced. Was it this one, or was it D90172

[PATCH] D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API

tianshilei1992 added a comment. This patch caused segment fault in D90099 where the map variable info pointer is `nullptr` but it is deferenced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89802/new/ https://rev

[PATCH] D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Nit: Add '.' add the end of comments and make them sentences. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89802/new/ https://revi

[PATCH] D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API

jdoerfert added a comment. Looks generally good. We seem to have way to many places dealing with the mapping stuff but that is not your fault. One thing I found weird though: Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8078 + for (auto LI = C->component_lists_begin(

[PATCH] D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API

jhuber6 added a comment. Initial version. This fails a few tests and needs additional test cases for the additional functionality as well as support inside the runtime library. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89802/new/ https://revie