This revision was automatically updated to reflect the committed changes.
Closed by commit rG0c66606230df: [Driver] Incorporate -mfloat-abi in the
computed triple on ARM (authored by john.brawn).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89573/ne
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89573/new/
https://reviews.llvm.org/D89573
___
cfe-commits mailing list
cfe-commits
john.brawn updated this revision to Diff 299420.
john.brawn edited the summary of this revision.
john.brawn added a comment.
Adjusted to give an error when the specified float abi is incompatible with the
default. Was a bit trickier than I expected as it required extracting out the
logic to dete
efriedma added inline comments.
Comment at: clang/lib/Driver/ToolChain.cpp:807
+default:
+ break;
+}
Do we want to error in the "default" case? Not that anyone is likely to use
-mfloat-abi on those targets, but I'd prefer not to silently miscompile
john.brawn created this revision.
john.brawn added reviewers: efriedma, vhscampos, chill.
Herald added subscribers: dexonsmith, steven_wu, hiraditya, kristof.beyls.
Herald added a project: clang.
john.brawn requested review of this revision.
LLVM assumes that when it creates a call to a C library
