[PATCH] D89571: [clangd] Add textDocument/ast extension method to dump the AST

2020-11-19 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/DumpASTTests.cpp:12 +#include "TestTU.h" +#include "llvm/Support/ScopedPrinter.h" +#include "gmock/gmock.h" sammccall wrote: > adamcz wrote: > > include order lint warning here > Not s

[PATCH] D89571: [clangd] Add textDocument/ast extension method to dump the AST

2020-11-19 Thread Sam McCall via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG8adc4d1ec764: [clangd] Add textDocument/ast extension method to dump the AST (authored by sammccall). Ch

[PATCH] D89571: [clangd] Add textDocument/ast extension method to dump the AST

2020-11-19 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/DumpASTTests.cpp:12 +#include "TestTU.h" +#include "llvm/Support/ScopedPrinter.h" +#include "gmock/gmock.h" adamcz wrote: > include order l

[PATCH] D89571: [clangd] Add textDocument/ast extension method to dump the AST

2020-10-29 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:799 + return CB(Offset.takeError()); +if (auto O = positionToOffset(Inputs->Inputs.Contents, R.end)

[PATCH] D89571: [clangd] Add textDocument/ast extension method to dump the AST

2020-10-28 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 301364. sammccall marked 2 inline comments as done. sammccall added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89571/new/ https://reviews.llvm.org/D89571 Files: clang-tools-e

[PATCH] D89571: [clangd] Add textDocument/ast extension method to dump the AST

2020-10-28 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:323 + /// Describe the AST subtree for a piece of code. + void getAST(PathRef File, Range, Callback>); + adamcz wrote: > Any reason

[PATCH] D89571: [clangd] Add textDocument/ast extension method to dump the AST

2020-10-26 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:795 +unsigned Start, End; +if (auto O = positionToOffset(Inputs->Inputs.Contents, R.start)) + Start = *O; Please rename O to anything else. *O below looks

[PATCH] D89571: [clangd] Add textDocument/ast extension method to dump the AST

2020-10-19 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 298961. sammccall added a comment. (for real this time) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89571/new/ https://reviews.llvm.org/D89571 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools

[PATCH] D89571: [clangd] Add textDocument/ast extension method to dump the AST

2020-10-19 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 298959. sammccall added a comment. Oops, forgot newly added files :-\ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89571/new/ https://reviews.llvm.org/D89571 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D89571: [clangd] Add textDocument/ast extension method to dump the AST

2020-10-16 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: adamcz. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgorny. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This is a mass-market ver