[PATCH] D89520: Don't permit array bound constant folding in OpenCL.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6781fee08505: Don't permit array bound constant folding in OpenCL. (authored by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D89520: Don't permit array bound constant folding in OpenCL.

rsmith updated this revision to Diff 299515. rsmith added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89520/new/ https://reviews.llvm.org/D89520 Files: clang/lib/AST/Decl.cpp clang/lib/AST/ExprConstant.cpp clang/lib/Sema

[PATCH] D89520: Don't permit array bound constant folding in OpenCL.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89520/new/ https://reviews.llvm.org/D89520 ___

[PATCH] D89520: Don't permit array bound constant folding in OpenCL.

Anastasia added a comment. In D89520#2335628 , @rsmith wrote: > In D89520#2334477 , @Anastasia wrote: > >>> I couldn't find any spec justification for accepting the kinds of cases >>> that D20090

[PATCH] D89520: Don't permit array bound constant folding in OpenCL.

rsmith updated this revision to Diff 298764. rsmith added a comment. Rebase on D89523 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89520/new/ https://reviews.llvm.org/D89520 Files: clang/lib/AST/ExprConstant.c

[PATCH] D89520: Don't permit array bound constant folding in OpenCL.

yaxunl added a comment. I am OK with the changes regarding null pointer. I guess people seldom set pointer to zero address in OpenCL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89520/new/ https://reviews.llvm.org/D89520 ___

[PATCH] D89520: Don't permit array bound constant folding in OpenCL.

rsmith added a comment. In D89520#2334477 , @Anastasia wrote: >> I couldn't find any spec justification for accepting the kinds of cases >> that D20090 accepts, so a reference to >> where in the OpenCL specification >> th

[PATCH] D89520: Don't permit array bound constant folding in OpenCL.

Anastasia added a comment. > Permitting non-standards-driven "do the best you can" constant-folding > of array bounds is permitted solely as a GNU compatibility feature. We > should not be doing it in any language mode that is attempting to be > conforming. > > From https://reviews.llvm.org/D20090

[PATCH] D89520: Don't permit array bound constant folding in OpenCL.

rsmith created this revision. rsmith added reviewers: Anastasia, bader, yaxunl. Herald added subscribers: kerbowa, nhaehnle, jvesely. Herald added a project: clang. rsmith requested review of this revision. Permitting non-standards-driven "do the best you can" constant-folding of array bounds is p