[PATCH] D89469: FileManager: Test FileManager::getFileRef

2020-10-20 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. Herald added a subscriber: ormris. In D89469#2342117 , @arphaman wrote: > Thanks. Could you expand the comment in the test that this test path > specifically exercises the behavior produced by the RedirectingFileSystem? Yup, d

[PATCH] D89469: FileManager: Test FileManager::getFileRef

2020-10-20 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG729d7d23282e: FileManager: Test FileManager::getFileRef (authored by dexonsmith). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D89469?vs=298379&id=299416#toc Reposit

[PATCH] D89469: FileManager: Test FileManager::getFileRef

2020-10-20 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. Thanks. Could you expand the comment in the test that this test path specifically exercises the behavior produced by the RedirectingFileSystem? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89469/new/ https://reviews.llvm.org/D89469 __

[PATCH] D89469: FileManager: Test FileManager::getFileRef

2020-10-15 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Add a test demonstrating `getFileRef`'s behaviour, which isn't obvious from code inspection when it's handling a redirected file. https://re