[PATCH] D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks"

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9e789447f14: Revert "[clang-format] Fix AlignConsecutive on PP blocks" (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89464/ne

[PATCH] D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks"

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89464/new/ https://reviews.llvm.org/D89464 _

[PATCH] D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks"

sylvestre.ledru updated this revision to Diff 298639. sylvestre.ledru added a comment. Add the test which was failing + add the previous tests (but disabled) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89464/new/ https://reviews.llvm.org/D89464

[PATCH] D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks"

MyDeveloperDay added a comment. LGTM, only keep the tests if they remain passing, otherwise perhaps @JakeMerdichAMD can add them back in. Could you add a test for the thing that broke to keep us honest? @JakeMerdichAMD when you get time, swing back round again with your fix because I think th

[PATCH] D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks"

sylvestre.ledru added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:12255 Alignment); - - // Bug 25167 lebedev.ri wrote: > Passing-by comment: you probably want to keep the tests though? Sure, i will keep that and add a test

[PATCH] D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks"

lebedev.ri added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:12255 Alignment); - - // Bug 25167 Passing-by comment: you probably want to keep the tests though? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks"

sylvestre.ledru created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. sylvestre.ledru requested review of this revision. This reverts commit b2eb439317576ce718193763c12bff9fccdfc166 . Cau