[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6ccff3d5f3b: [NewPM] Provide method to run all pipeline callbacks, used for -O0 (authored by aeubanks). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. In D89158#2389520 , @aeubanks wrote: > Thanks, I wasn't aware of this. Looks like other `opt -passes='default'` > tests also look at if it pres

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

aeubanks updated this revision to Diff 304657. aeubanks added a comment. forgot to amend commit with test updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89158/new/ https://reviews.llvm.org/D89158 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

asbirlea added a comment. AFAICT all issues were addressed. @Meinersbur: are there any concerns left with this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89158/new/ https://reviews.llvm.org/D89158

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

aeubanks added a comment. In D89158#2388991 , @Meinersbur wrote: > Could you try configuring LLVM with `-DLLVM_BYE_LINK_INTO_TOOLS=ON`? I assume > the test will break because it unconditionally adds a FunctionPass. Thanks, I wasn't aware of this. Looks l

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

aeubanks updated this revision to Diff 304617. aeubanks added a comment. fix tests when Bye plugin is present Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89158/new/ https://reviews.llvm.org/D89158 Files: clang/lib/CodeGen/BackendUtil.cpp cla

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

Meinersbur requested changes to this revision. Meinersbur added a comment. This revision now requires changes to proceed. Could you try configuring LLVM with `-DLLVM_BYE_LINK_INTO_TOOLS=ON`? I assume the test will break because it unconditionally adds a FunctionPass. Repository: rG LLVM Githu

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

aeubanks added a comment. With this change in its current state, it's ok to add callbacks, as long as they don't add passes at -O0. Polly adds some callbacks. When I first submitted this, polly would add some callbacks to VectorizerStartEPCallbacks. Those callbacks didn't actually add any passe

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

Meinersbur added a comment. My point is that it is possible for a pass plugin (such as `llvm/examples/Bye`) that can add themselves to the -O0 pipeline. If those plugins are linked statically, it will break tests that assume that no passes are added at those extension points. I don't quite und

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

aeubanks added a comment. In D89158#2384337 , @Meinersbur wrote: > In D89158#2384156 , @aeubanks wrote: > >> Are there passes that should be running at -O0 that aren't target specific? >> Otherwise the callbacks sh

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

Meinersbur added a comment. In D89158#2384156 , @aeubanks wrote: > Are there passes that should be running at -O0 that aren't target specific? > Otherwise the callbacks should only add passes if the optimization level > isn't -O0. At least for the legac

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

aeubanks added a comment. Are there passes that should be running at -O0 that aren't target specific? Otherwise the callbacks should only add passes if the optimization level isn't -O0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89158/new/ htt

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

Meinersbur added subscribers: serge-sans-paille, Meinersbur. Meinersbur added a comment. Did you consider just removing the `-NEXT` suffix? Polly might not be the only case, other statically linked pass-plugins may also insert themselves at extension points. @serge-sans-paille might have some i

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

aeubanks updated this revision to Diff 303737. aeubanks added a comment. Herald added a subscriber: dexonsmith. check if pass manager is empty before adding Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89158/new/ https://reviews.llvm.org/D89158 F

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

aeubanks reopened this revision. aeubanks added a comment. This revision is now accepted and ready to land. need to fix new-pass-manager.ll when polly is enabled Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89158/new/ https://reviews.llvm.org/D891

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

aeubanks added a comment. Sorry about that, https://reviews.llvm.org/D91019 should fix it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89158/new/ https://reviews.llvm.org/D89158 ___ cfe-commits mailing

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

nathanchance added a comment. $ cmake \ -G Ninja \ -DCMAKE_BUILD_TYPE=Release \ -DCMAKE_C_COMPILER=$(command -v clang) \ -DCMAKE_CXX_COMPILER=$(command -v clang++) \ -DLLVM_CCACHE_BUILD=ON \ -DLLVM_ENABLE_PROJECTS="clang;polly" \ -DLLVM_TARGETS_TO_BUILD=X86 \ -DLLVM_USE_LINKER=$(

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae3854004266: [NewPM] Provide method to run all pipeline callbacks, used for -O0 (authored by aeubanks). Changed prior to commit: https://reviews.

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

aeubanks added a comment. https://reviews.llvm.org/D90486 for adding OptimizationLevel to registerPassBuilderCallbacks(), although this one should land first since that one needs to update PassBuilder::runRegisteredEPCallbacks() to call TargetMachine::registerPassBuilderCallbacks() Repository