This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG412cdcf2edf2: [X86] Add HRESET instruction. (authored by
pengfei).
Changed prior to commit:
https://reviews.llvm.org/D89102?vs=297402&id=297732#to
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89102/new/
https://reviews.llvm.org/D89102
_
pengfei updated this revision to Diff 297402.
pengfei added a comment.
Rebased.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89102/new/
https://reviews.llvm.org/D89102
Files:
clang/docs/ClangCommandLineReference.rst
clang/include/clang/Driver
pengfei updated this revision to Diff 297234.
pengfei added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89102/new/
https://reviews.llvm.org/D89102
Files:
clang/docs/ClangCommandLineReference.rst
clang/incl
pengfei marked an inline comment as done.
pengfei added a comment.
Thanks for the review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89102/new/
https://reviews.llvm.org/D89102
___
cfe-commits mailing
RKSimon added a comment.
Please can you add a mention in the 12.0 release notes?
Comment at: llvm/lib/Target/X86/X86InstrInfo.td:2920
+ def HRESET : Ii8<0xF0, MRM_C0, (outs), (ins i32u8imm:$imm), "hreset\t$imm",
[]>,
+ Requires<[HasHRESET]>, TAXS;
+
pengfei created this revision.
pengfei added reviewers: craig.topper, RKSimon, LuoYuanke.
Herald added subscribers: llvm-commits, cfe-commits, dang, hiraditya, mgorny.
Herald added projects: clang, LLVM.
pengfei requested review of this revision.
For more details about these instructions, please r