[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7669f3c0f69d: Recommit "[CodeView] Emit static data members as S_CONSTANTs." (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang updated this revision to Diff 301080. akhuang added a comment. Herald added a subscriber: jfb. Moved isUnsignedDIType to DebugHandlerBase to avoid copying it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https://reviews.llvm.org

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang reopened this revision. akhuang added a comment. This revision is now accepted and ready to land. Reverted because my copied `isUnsignedDIType` function had problems (guess I copied it at first but then was messing with the code); I moved it to DebugHandlerBase.h so it doesn't need to be

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang added a comment. Patch to emit signed ints for other S_CONSTANTs: https://reviews.llvm.org/D90199 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https://reviews.llvm.org/D89072 ___ cfe-

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG515973222ed2: [CodeView] Emit static data members as S_CONSTANTs. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

rnk accepted this revision. rnk added a comment. lgtm Please fix this case in a follow-up, though: static const signed int gv_signed = 0x; const signed int useit2() { return gv_signed; } I think your `APSInt` code only works on static data member constants. Repository: rG LLVM G

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang updated this revision to Diff 300438. akhuang added a comment. Fix test failures; remove assert for signed APSInts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https://reviews.llvm.org/D89072 Files: clang/lib/CodeGen/CGDebug

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang marked an inline comment as done. akhuang added a comment. Whoops, forgot to check the tests. Apparently `mapEncodedInteger` asserts if a signed APInt is not less than 0. I just removed the assert because it doesn't seem necessary? Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

rnk added a comment. It seems like there are related test failures according to the Phabricator/Jenkins automation. Is that a true positive? Please confirm either way before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https:

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good with a test for explicit zero initialization. Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:3157 + +if (Value.isNullValue()) + continue; ---

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

dblaikie added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-static-member.cpp:144-147 +// For some reason, const_va is not emitted when the target is MS. +// NOT-MS: !DIDerivedType(tag: DW_TAG_member, name: "const_va", +// NOT-MS-SAME: line: [[@LINE-3]]

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-static-member.cpp:144-147 +// For some reason, const_va is not emitted when the target is MS. +// NOT-MS: !DIDerivedType(tag: DW_TAG_member, name: "const_va", +//

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang updated this revision to Diff 298258. akhuang marked an inline comment as done. akhuang added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https://reviews.llvm.org/D89072 Files: clang/lib/CodeGen/C

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

rnk added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-static-member.cpp:144-147 +// For some reason, const_va is not emitted when the target is MS. +// NOT-MS: !DIDerivedType(tag: DW_TAG_member, name: "const_va", +// NOT-MS-SAME: line: [[@LINE-3]] +//

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

dblaikie added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-static-member.cpp:144-147 +// For some reason, const_va is not emitted when the target is MS. +// NOT-MS: !DIDerivedType(tag: DW_TAG_member, name: "const_va", +// NOT-MS-SAME: line: [[@LINE-3]]

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang updated this revision to Diff 297068. akhuang added a comment. Update clang test for static data members, and make it test the general cases on the windows target as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https://rev

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang added a comment. In D89072#2320209 , @dblaikie wrote: > I'll probably leave the llvm/CodeView parts of this for @rnk - but for the > clang parts, they should have corresponding clang test coverage & I'd be > curious to see the test for that to un

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

dblaikie added a comment. I'll probably leave the llvm/CodeView parts of this for @rnk - but for the clang parts, they should have corresponding clang test coverage & I'd be curious to see the test for that to understand what the IR was before/after this change. (& to understand if/how either o

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. akhuang requested review of this revision. We used to only emit static const data members in CodeView as S_CONSTANTS when they