[PATCH] D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp).

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe3475f5b91c8: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp). (authored by Esme). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp).

steven.zhang added a comment. I think some follow up is needed to optimize the code sequence for cr = vec_test_div if (rotate_and_mask(cr, 62)) ... For now, we will copy the cr to gpr, and shift it to 61-64 bit,then, extract the bit and then compare to 0. the shift is not needed. Please

[PATCH] D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp).

steven.zhang accepted this revision. steven.zhang added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88278/new/ https://reviews.llvm.org/D88278 ___ cfe-commits mailing list cfe-commits@

[PATCH] D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp).

Esme added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:2584 +// Vector test software functions. +def : Pat<(i32 (int_ppc_vsx_xvtdivdp v2f64:$A, v2f64:$B)), steven.zhang wrote: > Vector test for software divide and sqrt I'll update it whe

[PATCH] D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp).

Esme added a comment. In D88278#2306618 , @amyk wrote: > Overall I think this LGTM. > > Please correct me if I am wrong but I think the description of the functions > need to be updated to: > > int vec_test_swdiv(vector double v1, vector double v2); >

[PATCH] D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp).

amyk accepted this revision as: amyk. amyk added a comment. This revision is now accepted and ready to land. Overall I think this LGTM. Please correct me if I am wrong but I think the description of the functions need to be updated to: int vec_test_swdiv(vector double v1, vector double v2);

[PATCH] D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp).

steven.zhang added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:2584 +// Vector test software functions. +def : Pat<(i32 (int_ppc_vsx_xvtdivdp v2f64:$A, v2f64:$B)), Vector test for software divide and sqrt Repository: rG LLVM Github M

[PATCH] D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp).

Esme created this revision. Esme added reviewers: steven.zhang, masoud.ataei, shchenz, jsji, qiucf. Herald added subscribers: llvm-commits, cfe-commits, kbarton, hiraditya, nemanjai. Herald added projects: clang, LLVM. Esme requested review of this revision. This patch implements the builtins for