[PATCH] D88250: [CUDA] Added dim3/uint3 conversion functions to builtin vars.

2020-09-24 Thread Artem Belevich via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG30514f0afa3e: [CUDA] Added conversion functions to builtin vars. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88250: [CUDA] Added dim3/uint3 conversion functions to builtin vars.

2020-09-24 Thread Artem Belevich via Phabricator via cfe-commits
tra marked an inline comment as done. tra added a comment. In D88250#2293346 , @tra wrote: > In D88250#2293270 , @jlebar wrote: > >> I know it comes in a separate change, but can we add a check to the >> test-suite

[PATCH] D88250: [CUDA] Added dim3/uint3 conversion functions to builtin vars.

2020-09-24 Thread Artem Belevich via Phabricator via cfe-commits
tra marked an inline comment as done. tra added a comment. In D88250#2293270 , @jlebar wrote: > I know it comes in a separate change, but can we add a check to the > test-suite? Will do. Comment at: clang/lib/Headers/__clang_cuda_runt

[PATCH] D88250: [CUDA] Added dim3/uint3 conversion functions to builtin vars.

2020-09-24 Thread Artem Belevich via Phabricator via cfe-commits
tra updated this revision to Diff 294125. tra edited the summary of this revision. tra added a comment. Fixed compatibility with pre-c++11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88250/new/ https://reviews.llvm.org/D88250 Files: clang/lib/

[PATCH] D88250: [CUDA] Added dim3/uint3 conversion functions to builtin vars.

2020-09-24 Thread Justin Lebar via Phabricator via cfe-commits
jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. I know it comes in a separate change, but can we add a check to the test-suite? Comment at: clang/lib/Headers/__clang_cuda_runtime_wrapper.h:381 +__device__ inline __cuda_bui

[PATCH] D88250: [CUDA] Added dim3/uint3 conversion functions to builtin vars.

2020-09-24 Thread Artem Belevich via Phabricator via cfe-commits
tra created this revision. tra added a reviewer: jlebar. Herald added subscribers: sanjoy.google, bixia, yaxunl. Herald added a project: clang. tra requested review of this revision. This is needed to compile some headers in CUDA-11 that assume that threadIdx is implicitly convertible to dim3. Wit