[PATCH] D87858: [hip] Add HIP scope atomic ops.

hliao added a comment. In D87858#3125630 , @yaxunl wrote: > Hi Michael, would you like to continue working on this, or let someone from > AMD to take over? Thanks. please take over it. I will abandon it so that you could start it over. Repository: rG

[PATCH] D87858: [hip] Add HIP scope atomic ops.

yaxunl added a comment. Hi Michael, would you like to continue working on this, or let someone from AMD to take over? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87858/new/ https://reviews.llvm.org/D87858 ___

[PATCH] D87858: [hip] Add HIP scope atomic ops.

hliao added a comment. PING for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87858/new/ https://reviews.llvm.org/D87858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D87858: [hip] Add HIP scope atomic ops.

hliao updated this revision to Diff 319013. hliao added a comment. Herald added a subscriber: dexonsmith. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87858/new/ https://reviews.llvm.org/D87858 Files: clang/include/clang/AST/Expr.h cla

[PATCH] D87858: [hip] Add HIP scope atomic ops.

jfb added a comment. In D87858#2282150 , @yaxunl wrote: > In D87858#2280429 , @jfb wrote: > >> Please provide documentation in this patch. > > opencl atomic builtins are documented as notes to `__c11_atomic builtins

[PATCH] D87858: [hip] Add HIP scope atomic ops.

yaxunl added a comment. In D87858#2280429 , @jfb wrote: > Please provide documentation in this patch. opencl atomic builtins are documented as notes to `__c11_atomic builtins` part of https://clang.llvm.org/docs/LanguageExtensions.html#builtin-functions.

[PATCH] D87858: [hip] Add HIP scope atomic ops.

t-tye added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:792-799 +ATOMIC_BUILTIN(__hip_atomic_compare_exchange_strong, "v.", "t") +ATOMIC_BUILTIN(__hip_atomic_exchange, "v.", "t") +ATOMIC_BUILTIN(__hip_atomic_fetch_add, "v.", "t") +ATOMIC_BUILTIN(__hip_atom

[PATCH] D87858: [hip] Add HIP scope atomic ops.

jfb added a comment. Please provide documentation in this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87858/new/ https://reviews.llvm.org/D87858 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D87858: [hip] Add HIP scope atomic ops.

t-tye added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:792-799 +ATOMIC_BUILTIN(__hip_atomic_compare_exchange_strong, "v.", "t") +ATOMIC_BUILTIN(__hip_atomic_exchange, "v.", "t") +ATOMIC_BUILTIN(__hip_atomic_fetch_add, "v.", "t") +ATOMIC_BUILTIN(__hip_atom

[PATCH] D87858: [hip] Add HIP scope atomic ops.

hliao updated this revision to Diff 292622. hliao added a comment. Revise formatting following the clang-format suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87858/new/ https://reviews.llvm.org/D87858 Files: clang/include/clang/AST/E

[PATCH] D87858: [hip] Add HIP scope atomic ops.

hliao added a comment. `singlethread` scope is added for completeness for the atomicity considering signal handling. It may not be applicable to GPU yet. We could simply ignore them in the late phases of the compiler. If desired, I may remove it as well. Repository: rG LLVM Github Monorepo

[PATCH] D87858: [hip] Add HIP scope atomic ops.

hliao created this revision. hliao added reviewers: yaxunl, b-sumner. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. hliao requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87858 Files: clang/include/clang/AST/Expr.h