[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mati865 abandoned this revision. mati865 added a comment. Opened https://reviews.llvm.org/D89225 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87547/new/ https://reviews.llvm.org/D87547 ___ cfe-commits m

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mstorsjo added a comment. In D87547#2323605 , @mati865 wrote: >> Or maybe even make it into a cmake option? > > I've considered it with default to true for unix and false for others but I'm > not sure if complicating Clang build options like that is worth

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mati865 added a comment. > Or maybe even make it into a cmake option? I've considered it as default to true for unix and false for others but I'm not sure if complicating Clang build options like that is worth it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mstorsjo added a comment. Out of these, the second (only enable on mingw if libllvm is available) sounds sensible to me. Or maybe even make it into a cmake option? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87547/new/ https://reviews.llvm.org/D

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mati865 added a comment. > Older versions of lld didn't error out if exceeding the limit, this is fixed > in D86701 , unfortunately after the 11 > branch. Thanks, I'll backport it for MSYS2 LLVM 11 package. > With -DLLVM_ENABLE_ASSERTIONS=ON -DCMAKE_C_COMPILER=

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mstorsjo added a comment. In D87547#2322900 , @mati865 wrote: > With `-DLLVM_ENABLE_ASSERTIONS=ON -DCMAKE_C_COMPILER=clang > -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_RANLIB_COMPILER=llvm-ranlib > -DCMAKE_AR_COMPILER=llvm-ar -DCMAKE_LINKER=ld.lld -DLLVM_ENABL

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mati865 added a comment. With `-DLLVM_ENABLE_ASSERTIONS=ON -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_RANLIB_COMPILER=llvm-ranlib -DCMAKE_AR_COMPILER=llvm-ar -DCMAKE_LINKER=ld.lld -DLLVM_ENABLE_LLD=ON` libclang-cpp.dll has 65535 exports, seems it got truncated? Repository:

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mati865 added a comment. Reproduced by adding `-DLLVM_ENABLE_ASSERTIONS=ON`. With `-DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_BUILD_LLVM_DYLIB=ON -DLLVM_LINK_LLVM_DYLIB=ON` libLLVM.dll also fails to link. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8754

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mstorsjo added a comment. In D87547#2322643 , @mati865 wrote: >> How many exports does your DLL end up with - is it close to the 64k limit, >> or far from it? Is there maybe some other library that is linked in, that >> increases the number of exported s

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mati865 added a comment. > How many exports does your DLL end up with - is it close to the 64k limit, or > far from it? Is there maybe some other library that is linked in, that > increases the number of exported symbols (=all), or does this DLL only export > explicitly intended symbols with dl

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

ASDenysPetrov added a comment. In D87547#2322325 , @mati865 wrote: > @ASDenysPetrov what CMake options do you use? > I'm unable to reproduce this error with Clang+LLD and GCC+Binutils from MSYS2. Sorry for not mentioning that. This is my cmd: cmake -GN

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mstorsjo added a comment. In D87547#2322325 , @mati865 wrote: > @ASDenysPetrov what CMake options do you use? > I'm unable to reproduce this error with Clang+LLD and GCC+Binutils from MSYS2. How many exports does your DLL end up with - is it close to the

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mati865 added a comment. @ASDenysPetrov what CMake options do you use? I'm unable to reproduce this error with Clang+LLD and GCC+Binutils from MSYS2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87547/new/ https://reviews.llvm.org/D87547

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

ASDenysPetrov reopened this revision. ASDenysPetrov added a comment. This revision is now accepted and ready to land. Hi, @mati865 Currently I got an error while building with GCC10 on Win10. [2325/2656] Linking CXX shared library bin\libclang-cpp.dll FAILED: bin/libclang-cpp.dll lib/libclang

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb613044b680: [MinGW][clang-shlib] Build by default on MinGW (authored by mati865, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8754

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. This should be ok, I think. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87547/new/ https://reviews.llvm.org/D87547 __

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mati865 created this revision. mati865 added a reviewer: clang. mati865 added a project: clang. Herald added subscribers: cfe-commits, mgorny. mati865 requested review of this revision. It builds without errors and makes possible to use `CLANG_LINK_CLANG_DYLIB=1` Repository: rG LLVM Github Mon