[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a0a2a6347f5: [clangd] Implement hot index reloading for clangd-index-server (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:342 + HotReloadThread.join(); } kbobyrev wrote: > kadircet wrote: > >

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:234 + LastStatus.getLastModificationTime(), Status->getLastModificationTime()); + std::unique_ptr NewIndex = loadIndex(IndexPath); + if (!NewIndex) { kadi

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev updated this revision to Diff 292144. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Save last status to prevent redundant updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87450/new/ https://reviews.llvm.org/D87

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:234 + LastStatus.getLastModificationTime(), Status->getLastModificationTime()); + std::unique_ptr NewIndex = loadIndex(IndexPath); + if (!NewIndex) { kbob

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev updated this revision to Diff 292131. kbobyrev added a comment. Update comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87450/new/ https://reviews.llvm.org/D87450 Files: clang-tools-extra/clangd/index/remote/server/Server.cpp Ind

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:234 + LastStatus.getLastModificationTime(), Status->getLastModificationTime()); + std::unique_ptr NewIndex = loadIndex(IndexPath); + if (!NewIndex) { kadi

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev updated this revision to Diff 292130. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address another round of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87450/new/ https://reviews.llvm.org/D87450 Files:

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kadircet added a comment. oops, looks like i forgot to hit submit in the morning.. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:228 + auto Status = FS->status(IndexPath); + if (!Status || Status->equivalent(LastStatus)) +return; i b

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev updated this revision to Diff 291861. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address a round of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87450/new/ https://reviews.llvm.org/D87450 Files: clan

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kadircet added a comment. Thanks! Mostly looks good, just couple of nits. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:223 +// whenever they become available. +void hotReload(clangd::SwapIndex *Index, llvm::StringRef IndexPath, + llvm::vfs::

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev updated this revision to Diff 291521. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address remaining comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87450/new/ https://reviews.llvm.org/D87450 Files: clang

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:226 + llvm::sys::TimePoint<> LastModificationTime = + std::chrono::system_clock::now(); + for (;; std::this_thread::sleep_for(std::chrono::seconds(90))) { k

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:226 + llvm::sys::TimePoint<> LastModificationTime = + std::chrono::system_clock::now(); + for (;; std::this_thread::sleep_for(std::chrono::seconds(90))) { k

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev updated this revision to Diff 291508. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87450/new/ https://reviews.llvm.org/D87450 Files: clang-to

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:71 std::unique_ptr openIndex(llvm::StringRef Index) { return loadIndex(Index, /*UseIndex=*/true); why do we have this extra indirection? C

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This patch adds a mechanism to load