[PATCH] D87352: Fix typo

2020-09-16 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:778 - For example: __capability. - MyDeveloperDay wrote: > So this is an example of where someone has changed the .rst and not the > Format.h! @arichardson > > I recommend

[PATCH] D87352: Fix typo

2020-09-16 Thread MyDeveloperDay via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4dd9c709ef1b: [clang-format] [NFC] Fix spelling mistake in the documentation (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8735

[PATCH] D87352: Fix typo

2020-09-16 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a subscriber: arichardson. MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:778 - For example: __capability. - So this is an example of where someone has changed the .rst and not the Format.h! @aric

[PATCH] D87352: Fix typo

2020-09-15 Thread YangZhihui via Phabricator via cfe-commits
YangZhihui updated this revision to Diff 292076. YangZhihui retitled this revision from "Fix typo in Format.h" to "Fix typo". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87352/new/ https://reviews.llvm.org/D87352 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/For

[PATCH] D87352: Fix typo in Format.h

2020-09-15 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Ok almost... so you change the Format.h, then run the docs/tools/clang_format_stype.py and attach both the rst and the .h to the review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87352/new/ https://reviews.llvm.org/D87352 ___

[PATCH] D87352: Fix typo in Format.h

2020-09-15 Thread YangZhihui via Phabricator via cfe-commits
YangZhihui added a comment. In D87352#2273349 , @MyDeveloperDay wrote: > I have realized this is the wrong change > > The actual error is in Format.h > > clang/docs/ClangFormatStyleOption.rst is generated using the > clang/docs/tools/dump_format_style.py

[PATCH] D87352: Fix typo in Format.h

2020-09-15 Thread YangZhihui via Phabricator via cfe-commits
YangZhihui updated this revision to Diff 291825. YangZhihui retitled this revision from "Fix typo in doc ClangFormatStyleOptions.rst" to "Fix typo in Format.h". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87352/new/ https://reviews.llvm.org/D87352 Files: clang/include/clang/Format/F

[PATCH] D87352: Fix typo in doc ClangFormatStyleOptions.rst

2020-09-15 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. I have realized this is the wrong change The actual error is in Format.h clang/docs/ClangFormatStyleOption.rst is generated using the clang/docs/tools/dump_format_st

[PATCH] D87352: Fix typo in doc ClangFormatStyleOptions.rst

2020-09-15 Thread YangZhihui via Phabricator via cfe-commits
YangZhihui added a comment. In D87352#2263416 , @MyDeveloperDay wrote: > LGTM, thank you for doing this.. Thanks, may me you can help me commit it : ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87352/n

[PATCH] D87352: Fix typo in doc ClangFormatStyleOptions.rst

2020-09-09 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM, thank you for doing this.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87352/new/ https://reviews.llvm.org/D87352 _

[PATCH] D87352: Fix typo in doc ClangFormatStyleOptions.rst

2020-09-09 Thread YangZhihui via Phabricator via cfe-commits
YangZhihui added a comment. I don't have commit access. Please help me commit it. Thanks : ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87352/new/ https://reviews.llvm.org/D87352 ___ cfe-commits maili

[PATCH] D87352: Fix typo in doc ClangFormatStyleOptions.rst

2020-09-09 Thread YangZhihui via Phabricator via cfe-commits
YangZhihui created this revision. YangZhihui added a reviewer: MyDeveloperDay. Herald added a project: clang. Herald added a subscriber: cfe-commits. YangZhihui requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87352 Files: clang/docs/ClangForma