[PATCH] D86841: [clang] Add noprogress attribute deduction for infinite loops

2020-09-03 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel updated this revision to Diff 289849. atmnpatel added a comment. In Summary: - I changed the llvm loop metadata name to `mustprogress`, to indicate that loops with this attribute are required to have side-effects. - The `mayprogress` function attribute is applied to functions where an

[PATCH] D86841: [clang] Add noprogress attribute deduction for infinite loops

2020-09-03 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel marked an inline comment as done. atmnpatel added inline comments. Comment at: clang/lib/CodeGen/CGLoopInfo.h:211 llvm::ArrayRef Attrs, const llvm::DebugLoc &StartLoc, -const llvm::DebugLoc &EndLoc); +const llvm::DebugLoc &EndLoc, co

[PATCH] D86841: [clang] Add noprogress attribute deduction for infinite loops

2020-09-03 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel updated this revision to Diff 289821. atmnpatel added a comment. Herald added a subscriber: zzheng. Renamed llvm loop metadata, changed deduction rules. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86

[PATCH] D86841: [clang] Add noprogress attribute deduction for infinite loops

2020-08-31 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGLoopInfo.h:211 llvm::ArrayRef Attrs, const llvm::DebugLoc &StartLoc, -const llvm::DebugLoc &EndLoc); +const llvm::DebugLoc &EndLoc, const bool NoProgress = false);