hokein closed this revision.
hokein added a comment.
committed in
https://github.com/llvm/llvm-project/commit/5d21aedfdbf0b85d65bad08b7b89913205de4b33.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86688/new/
https://reviews.llvm.org/D86688
_
hokein updated this revision to Diff 288543.
hokein marked 4 inline comments as done.
hokein added a comment.
address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86688/new/
https://reviews.llvm.org/D86688
Files:
clang/docs/ReleaseNote
sammccall added inline comments.
Comment at: clang/docs/ReleaseNotes.rst:65
+
+ .. code-block:: c++
+
Oops, I missed this, I think this should be three code blocks: one for C++, one
for the first AST and one for the second AST.
Tex like "clang-10 produces the m
tschuett added inline comments.
Comment at: clang/docs/ReleaseNotes.rst:73
+
+ // clangd-11 produces a richer AST:
+ // VarDecl col:5 x 'int' cinit
clangd-11 or clang-11?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://review
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/docs/ReleaseNotes.rst:51
+Recovery ASTs
+^
nit: AST rather than ASTs (matching the flag, and also it's AST is singu
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added a project: clang.
hokein requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D86688
Files:
clang/docs/ReleaseNotes.rst
Index: clang/docs/ReleaseNotes.rst
=
