This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGfda3fa822cb6: [SyntaxTree][NFC] Append "get" to
syntax Nodes accessor names (authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES
gribozavr2 accepted this revision.
gribozavr2 added a comment.
This revision is now accepted and ready to land.
> It's worth noting that accessors in the base APIs don't follow this rule.
> Should we refactor them as well?
I'd say yes.
> In this patch?
Up to you.
Repository:
rG LLVM Github
eduucaldas added a reviewer: gribozavr2.
eduucaldas added a comment.
It's worth noting that accessors in the base APIs don't follow this rule.
Should we refactor them as well? In this patch?
Examples:
class Arena {
public:
const SourceManager &sourceManager() const { return SourceMgr; }
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D86679
Files:
clang/include/clang/Tooling/Syntax/Nodes.h
clang/lib/Tooling/Syn
