[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang closed this revision. akhuang added a comment. ah sorry, this was relanded in b1009ee84fc0242bcebd07889306bf39d9b7170f . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8649

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

dblaikie accepted this revision. dblaikie added a comment. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86491/new/ https://reviews.llvm.org/D86491 ___ cfe-commits mailing list cfe-co

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang updated this revision to Diff 287748. akhuang added a comment. Fix errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86491/new/ https://reviews.llvm.org/D86491 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-in

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang reopened this revision. akhuang added a comment. This revision is now accepted and ready to land. just reopening to update the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86491/new/ https://reviews.llvm.org/D86491 _

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang added a comment. In D86491#2235206 , @MaskRay wrote: > Note that Harbormaster actually reported the check-clang-codegencxx issues > B69369 .. Definitely my bad; I thought I had run check-clang locally before commi

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

MaskRay added a comment. Note that Harbormaster actually reported the check-clang-codegencxx issues B69369 .. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86491/new/ https://reviews.llvm.org/D86491 __

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG589ce5f7050d: [DebugInfo] Move constructor homing case in shouldOmitDefinition. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang added a comment. unfortunately not any thorough testing :) I just happened to notice it the last time I looked at this code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86491/new/ https://reviews.llvm.org/D86491

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Thanks for testing/catching this (what sort of testing have you been doing that discovered this?)! & yeah, the way shouldOmitDefinition is now written (with this fix) is right - that ever

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang created this revision. akhuang added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. For some reason the ctor homing case was before the template specialization case, and could have returned false too e