[PATCH] D85933: Don't track consteval references for dependent members

2020-08-14 Thread Wyatt Childers via Phabricator via cfe-commits
wchilders added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:1761 + llvm::SaveAndRestore DisableIITracking( + S.RebuildingImmediateInvocation, true); + Tyker wrote: > I don't think RebuildingImmediateInvocation should be used here si

[PATCH] D85933: Don't track consteval references for dependent members

2020-08-14 Thread Tyker via Phabricator via cfe-commits
Tyker added a comment. thanks for this, here is a few comments aside from that this seems fine. Comment at: clang/lib/Sema/SemaOverload.cpp:1761 + llvm::SaveAndRestore DisableIITracking( + S.RebuildingImmediateInvocation, true); + I don't think R

[PATCH] D85933: Don't track consteval references for dependent members

2020-08-13 Thread Wyatt Childers via Phabricator via cfe-commits
wchilders created this revision. wchilders added reviewers: Tyker, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. wchilders requested review of this revision. Previously dependent references to consteval (`ReferenceToConsteval`) were tracked, and dependent expressi