This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGbd1013a4825b: [clangd] Enforce trailing slash for remote
index's project root (authored by kbobyrev).
Repository:
rG LLVM Github Monorepo
CHANGES
kbobyrev updated this revision to Diff 284648.
kbobyrev added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85711/new/
https://reviews.llvm.org/D85711
Files:
clang-tools-extra/clangd/index/remote/Client.cpp
clang-tools-extra
kbobyrev updated this revision to Diff 284611.
kbobyrev added a comment.
Remove redundant `.str()` calls.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85711/new/
https://reviews.llvm.org/D85711
Files:
clang-tools-extra/clangd/index/remote/Clien
kbobyrev updated this revision to Diff 284609.
kbobyrev marked an inline comment as done.
kbobyrev added a comment.
Handle slash appending in Marshaller.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85711/new/
https://reviews.llvm.org/D85711
File
hokein added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:387
+ !llvm::StringRef(ProjectRoot).endswith(llvm::sys::path::get_separator()))
+ProjectRoot += llvm::sys::path::get_separator();
+
Instead of handling this in all
kbobyrev created this revision.
kbobyrev added a reviewer: hokein.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous.
Herald added a project: clang.
kbobyrev requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Repository:
rG LLVM Githu
