[PATCH] D85635: [clangd] Compute the inactive code range for semantic highlighting.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0aaa2acc4ca0: [clangd] Compute the inactive code range for semantic highlighting. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85635/n

[PATCH] D85635: [clangd] Compute the inactive code range for semantic highlighting.

hokein updated this revision to Diff 287405. hokein marked an inline comment as done. hokein added a comment. Herald added a subscriber: mgrang. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85635/new/ https://reviews.llvm.org/D856

[PATCH] D85635: [clangd] Compute the inactive code range for semantic highlighting.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. I think the code could be a bit clearer, but up to you. The tests are good so feel free to submit any version you're happy with. Comment at: clang-tools-extra/clangd/S

[PATCH] D85635: [clangd] Compute the inactive code range for semantic highlighting.

hokein updated this revision to Diff 284715. hokein marked 3 inline comments as done. hokein added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85635/new/ https://reviews.llvm.org/D85635 Files: clang-tools-ext

[PATCH] D85635: [clangd] Compute the inactive code range for semantic highlighting.

sammccall added a comment. Yup, this is a nice improvement, though there are further things we could do. As discussed offline, we could consider mapping "disabled" to an attribute but we can't really consume that well in VSCode (or any other editor yet) so let's leave it. Co

[PATCH] D85635: [clangd] Compute the inactive code range for semantic highlighting.

hokein added a comment. In D85635#2208325 , @nridge wrote: > Do you mean "inactive" (instead of "interactive") in the commit message? oh, right. Fixed the typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/