[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

eduucaldas updated this revision to Diff 284344. eduucaldas added a comment. lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85440/new/ https://reviews.llvm.org/D85440 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Synt

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

eduucaldas updated this revision to Diff 284342. eduucaldas added a comment. Answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85440/new/ https://reviews.llvm.org/D85440 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/T

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/Tree.cpp:362 + switch (this->kind()) { + case NodeKind::NestedNameSpecifier: { +return clang::tok::coloncolon; Please drop the braces within 'case' unl

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

eduucaldas updated this revision to Diff 284324. eduucaldas added a comment. Implement `canBeEmpty`, `getDelimiterToken`, `getTerminationKind` for `NestedNameSpecifier` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85440/new/ https://reviews.llvm.

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

gribozavr2 added a comment. LGTM after my comments are addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85440/new/ https://reviews.llvm.org/D85440 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

gribozavr2 added a comment. Could you add unit tests for methods in List and NNS? OK if they are in a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85440/new/ https://reviews.llvm.org/D85440 ___

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

gribozavr2 added a comment. Please also add appropriate handling to `syntax::List::getDelimiterTokenKind`, `getTerminationKind`, and `canBeEmpty`. Comment at: clang/lib/Tooling/Syntax/Nodes.cpp:240 return Children; -} +}; Repository: rG LLVM Github M

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

eduucaldas updated this revision to Diff 283643. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85440/new/ https://reviews.llvm.org/D85440 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

eduucaldas updated this revision to Diff 283638. eduucaldas added a comment. Clean List specific code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85440/new/ https://reviews.llvm.org/D85440 Files: clang/include/clang/Tooling/Syntax/Nodes.h cl

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85440 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/include/clang/T