eduucaldas added inline comments.
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:3363
+| |-'if' IntroducerKeyword I
+| |-'(' I
+| |-BinaryOperatorExpression I
Some points to make a decision.
What should be the order of these extra informatio
eduucaldas updated this revision to Diff 283513.
eduucaldas added a comment.
Reflect comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85316/new/
https://reviews.llvm.org/D85316
Files:
clang/unittests/Tooling/Syntax/TreeTest.cpp
Index: cl
gribozavr2 added a comment.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85316/new/
https://reviews.llvm.org/D85316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
eduucaldas updated this revision to Diff 283298.
eduucaldas added a comment.
Answering comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85316/new/
https://reviews.llvm.org/D85316
Files:
clang/unittests/Tooling/Syntax/TreeTest.cpp
Index:
gribozavr2 added a comment.
I'd suggest to drop the `<>` quotes (because the AST dump does not add quotes
unless it is printing a multi-word thing, and because `<>` don't exactly scream
"role" helping to read the output).
I'd also suggest to replace multiple spaces before `<>` with a single spa
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Some key choices to highlight:
- Surround Tokens with "''"
- Do not print `UnknownRole`, to reduce noise
- Surround Roles with "<", to clarify the
