[PATCH] D84846: [MC] Add support for generating missing GNU build notes

tbaeder updated this revision to Diff 316945. tbaeder added a comment. Sorry about the last change, that was the wrong patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84846/new/ https://reviews.llvm.org/D84846 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/c

[PATCH] D84846: [MC] Add support for generating missing GNU build notes

tbaeder updated this revision to Diff 316944. Herald added a subscriber: martong. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84846/new/ https://reviews.llvm.org/D84846 Files: clang/include/clang/AST/Expr.h clang/include/clang/AST/RecursiveASTVisitor.h clang/include/clang/Basic/S

[PATCH] D84846: [MC] Add support for generating missing GNU build notes

tbaeder added a comment. In D84846#2396303 , @MaskRay wrote: > https://fedoraproject.org/wiki/Toolchain/Watermark Seems that > `.gnu.build.attributes` is used with a GCC plugin (annobin?). The feature on > its own is probably not that useful. `.gnu.linko

[PATCH] D84846: [MC] Add support for generating missing GNU build notes

MaskRay added a comment. Herald added a subscriber: dexonsmith. https://fedoraproject.org/wiki/Toolchain/Watermark Seems that `.gnu.build.attributes` is used with a GCC plugin (annobin?). The feature on its own is probably not that useful. `.gnu.linkonce` is a proto-comdat legacy feature which

[PATCH] D84846: [MC] Add support for generating missing GNU build notes

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84846/new/ https://reviews.llvm.org/D84846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D84846: [MC] Add support for generating missing GNU build notes

tbaeder updated this revision to Diff 284308. tbaeder added a comment. Add a test that checks that clang accepts `-Wa,--generate-missing-build-notes=yes` and `-Wa,--generate-missing-build-notes=no` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84846/new/ https://reviews.llvm.org/D8484

[PATCH] D84846: [MC] Add support for generating missing GNU build notes

tbaeder created this revision. Herald added subscribers: llvm-commits, cfe-commits, dang, hiraditya, emaste. Herald added a reviewer: espindola. Herald added projects: clang, LLVM. tbaeder requested review of this revision. Herald added a subscriber: MaskRay. Add support for generating missing GNU