aheejin added inline comments.
Comment at: llvm/test/CodeGen/WebAssembly/simd-widening.ll:113
+
+;; Also test that similar patterns are still expanded correctly
+
tlively wrote:
> aheejin wrote:
> > tlively wrote:
> > > aheejin wrote:
> > > > It'd be clearer to s
tlively added inline comments.
Comment at: llvm/test/CodeGen/WebAssembly/simd-widening.ll:113
+
+;; Also test that similar patterns are still expanded correctly
+
aheejin wrote:
> tlively wrote:
> > aheejin wrote:
> > > It'd be clearer to say starting indices of
aheejin added inline comments.
Comment at: llvm/test/CodeGen/WebAssembly/simd-widening.ll:113
+
+;; Also test that similar patterns are still expanded correctly
+
tlively wrote:
> aheejin wrote:
> > It'd be clearer to say starting indices of these don't start wit
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG11bb7eef4152: [WebAssembly] Remove intrinsics for SIMD
widening ops (authored by tlively).
Changed prior to commit:
https://reviews.llvm.org/D8455
tlively added inline comments.
Comment at: llvm/test/CodeGen/WebAssembly/simd-widening.ll:113
+
+;; Also test that similar patterns are still expanded correctly
+
aheejin wrote:
> It'd be clearer to say starting indices of these don't start with 0 or
> [lanecoun
aheejin accepted this revision.
aheejin added inline comments.
This revision is now accepted and ready to land.
Comment at: llvm/test/CodeGen/WebAssembly/simd-widening.ll:113
+
+;; Also test that similar patterns are still expanded correctly
+
It'd be clearer to
tlively created this revision.
tlively added a reviewer: aheejin.
Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya,
jgravelle-google, sbc100, dschuff.
Herald added projects: clang, LLVM.
Instead, pattern match extends of extract_subvectors to generate
widening operations. S
