[PATCH] D84473: Dump Accumulator

jhenderson added a comment. By the way, has the design of this been discussed on llvm-dev? It seems like something should have an RFC if it hasn't already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84473/new/ https://reviews.llvm.org/D84473 _

[PATCH] D84473: Dump Accumulator

jhenderson requested changes to this revision. jhenderson added a comment. This revision now requires changes to proceed. I'm assuming you need llvm-readobj to test your changes? In which case, the llvm-readobj change needs to come first, and then you can write tests using it to test this change

[PATCH] D84473: Dump Accumulator

kazu updated this revision to Diff 281344. kazu added a comment. Spun off the llvm-readobj bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84473/new/ https://reviews.llvm.org/D84473 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm

[PATCH] D84473: Dump Accumulator

kazu added a comment. In D84473#2178167 , @jhenderson wrote: > Could the llvm-readobj bit be spun off into a separate review, please. As > things stand it doesn't have any of its own testing, which should be added at > the same time as adding support in

[PATCH] D84473: Dump Accumulator

jhenderson added a comment. Could the llvm-readobj bit be spun off into a separate review, please. As things stand it doesn't have any of its own testing, which should be added at the same time as adding support in the tool itself. The new option is also lacking any documentation in the llvm-re

[PATCH] D84473: Dump Accumulator

mtrofin accepted this revision. mtrofin added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84473/new/ https://reviews.llvm.org/D84473 _

[PATCH] D84473: Dump Accumulator

mtrofin added inline comments. Comment at: llvm/include/llvm/Analysis/DumpAccumulator.h:43 +// +// Note that ThinLTO is not supported yet. +// kazu wrote: > mtrofin wrote: > > I'd clarify that transferring the data from pre-link thinlto to post-link > > isn't su

[PATCH] D84473: Dump Accumulator

kazu marked an inline comment as done. kazu added inline comments. Comment at: llvm/include/llvm/Analysis/DumpAccumulator.h:43 +// +// Note that ThinLTO is not supported yet. +// mtrofin wrote: > I'd clarify that transferring the data from pre-link thinlto to pos

[PATCH] D84473: Dump Accumulator

mtrofin added inline comments. Comment at: llvm/include/llvm/Analysis/DumpAccumulator.h:43 +// +// Note that ThinLTO is not supported yet. +// I'd clarify that transferring the data from pre-link thinlto to post-link isn't supported, but one could use this in po

[PATCH] D84473: Dump Accumulator

kazu created this revision. kazu added reviewers: davidxl, mtrofin, wmi. kazu added a project: LLVM. Herald added subscribers: cfe-commits, rupprecht, MaskRay, hiraditya, mgorny. Herald added a reviewer: jhenderson. Herald added a project: clang. This patch adds a utility called DumpAccumulator.