kadircet added a comment.
> the test.h in the patch description is missing a #define X.
ah right, git descriptions omitting lines starting with `#` fixed it for
include, but missed the define :face_palm:
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:383
+
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa69f9a8584f2: [clangd] Fix Origin and MainFileOnly-ness for
macros (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84297/new/
https://
kadircet updated this revision to Diff 279731.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Move declarations closer to use.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84297/new/
https://reviews.llvm.org/D84297
Files:
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
thanks!
the test.h in the patch description is missing a `#define X`.
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:383
+ !isHeaderFile(SM.getFileEntry
kadircet created this revision.
kadircet added a reviewer: hokein.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
This was resulting in macros coming from preambles vanishing when user
have opened the source header. For
