[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

kbobyrev added a comment. In D84172#2166503 , @ilya-golovenko wrote: > In D84172#2166496 , @kbobyrev wrote: > > > In D84172#2166448 , > > @ilya-golovenko wrote: > > > > > @

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko added a comment. In D84172#2166496 , @kbobyrev wrote: > In D84172#2166448 , @ilya-golovenko > wrote: > > > @kbobyrev Kirill, thank you for landing this for me! Unfortunately @walrus > > is my not-us

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

walrus added a comment. In D84172#2166496 , @kbobyrev wrote: > In D84172#2166448 , @ilya-golovenko > wrote: > > > @kbobyrev Kirill, thank you for landing this for me! Unfortunately @walrus > > is my not-used-anymo

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

kbobyrev added a comment. In D84172#2166448 , @ilya-golovenko wrote: > @kbobyrev Kirill, thank you for landing this for me! Unfortunately @walrus is > my not-used-anymore account... > By the way, do you know is it possible to delete my unused account @w

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko added a subscriber: walrus. ilya-golovenko added a comment. @kbobyrev Kirill, thank you for landing this for me! Unfortunately @walrus is my not-used-anymore account... By the way, do you know is it possible to delete my unused account @walrus to avoid such confusions in future?

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3975c3be8041: [clangd] Fix conversion from Windows UNC paths to file URI format. (authored by walrus, committed by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko added a comment. @sammccall sorry for bothering you, could you please land this for me? Ilya Golovenko Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84172/new/ https://reviews.llvm.org/D84172

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko added a comment. In D84172#2162736 , @sammccall wrote: > Thanks! Do you have commit access, or should I land this for you? No, I don't have commit access. Could you please commit on my behalf? Ilya Golovenko And thanks again for the rev

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Do you have commit access, or should I land this for you? Comment at: clang-tools-extra/clangd/URI.cpp:29 +bool isWindowsPath(llvm::StringRef Path) { + retur

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko added a comment. In D84172#2162284 , @sammccall wrote: > Thanks for doing this! And sorry about the shaky windows support... > > (There are potentially other lurking issues due to filenames being used as > keys internally, particularly case

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko marked 2 inline comments as done. ilya-golovenko added inline comments. Comment at: clang-tools-extra/clangd/URI.cpp:29 +bool isWindowsPath(llvm::StringRef Path) { + return Path.size() > 1 && llvm::isAlpha(Path[0]) && Path[1] == ':'; sammccall w

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko updated this revision to Diff 279271. ilya-golovenko marked an inline comment as done. ilya-golovenko added a comment. Address code review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84172/new/ https://reviews.llvm.org/D8

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

sammccall added a comment. Thanks for doing this! And sorry about the shaky windows support... (There are potentially other lurking issues due to filenames being used as keys internally, particularly case-insensitivity issues...) Comment at: clang-tools-extra/clangd/URI.cpp:2

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko created this revision. Herald added subscribers: cfe-commits, kbobyrev, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The fix improves handling of Windows UNC paths to align with Appendix E. Nonstandard Syntax Variations of RFC 8089