[PATCH] D84067: Fix issue in typo handling which could lead clang to hang

2020-07-20 Thread David Goldman via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdde98c82c0ad: Fix issue in typo handling which could lead clang to hang (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84067/new/ htt

[PATCH] D84067: Fix issue in typo handling which could lead clang to hang

2020-07-17 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 278890. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84067/new/ https://reviews.llvm.org/D84067 Files: clang/include/clang/Sema/SemaInternal.h clang/lib/Sema/SemaExprCXX.

[PATCH] D84067: Fix issue in typo handling which could lead clang to hang

2020-07-17 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 278881. dgoldman added a comment. - CheckAndAdvanceTypoExprCorrectionStreams comment fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84067/new/ https://reviews.llvm.org/D84067 Files: clang/include/clang/S

[PATCH] D84067: Fix issue in typo handling which could lead clang to hang

2020-07-17 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 278876. dgoldman added a comment. - Minor comment fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84067/new/ https://reviews.llvm.org/D84067 Files: clang/include/clang/Sema/SemaInternal.h clang/lib/Sema

[PATCH] D84067: Fix issue in typo handling which could lead clang to hang

2020-07-17 Thread David Goldman via Phabricator via cfe-commits
dgoldman created this revision. dgoldman added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. We need to detect when certain TypoExprs are not being transformed due to invalid trees, otherwise we risk endlessly trying to fix it. Repository: rG LLVM G