This revision was automatically updated to reflect the committed changes.
Closed by commit rG46c921003c2c: [clangd] Always retrieve ProjectInfo from Base
in OverlayCDB (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83934/new/
kadircet updated this revision to Diff 278421.
kadircet added a comment.
- Split comments between implementation and header, and reword.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83934/new/
https://reviews.llvm.org/D83934
Files:
clang-tools-
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.h:136
tooling::CompileCommand getFallbackCommand(PathRef File) const override;
+ /// Note that pr
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
Clangd is returning current working directory for overriden commands.
This can cause inconsistencies be
