[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9b6765e784b3: [clangd] Add Random Forest runtime for code completion. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 292828. usaxena95 added a comment. Fixed output_dir cmake variable. Clean build succeeds now. Ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files:

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 292818. usaxena95 added a comment. Removed generated (for review) files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files: clang-tools-extra/clangd/CMakeLists.

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG from my side! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 ___

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 292717. usaxena95 marked 12 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files: clang-too

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 marked an inline comment as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/quality/CompletionModel.cmake:13 + + set(output_dir ${CMAKE_BINARY_DIR}/generated/decision_forest) + set(header_file ${output_dir}/${filename}.h)

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

sammccall added a comment. Just some naming and doc nits. This looks really solid now, nice job! In D83814#2261458 , @jkorous wrote: > Hi @usaxena95 and @sammccall, > > I am wondering about couple high-level things. > > Do you guys intend to open-source a

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/quality/CompletionModelCodegen.py:39 +'''Returns the header guard for the generated header.''' +return "GENERATED_DECISION_FOREST_MODEL_{}_H".format(filename.upper()) + adamcz wrote: >

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 292188. usaxena95 marked 8 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files: clang-tool

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

adamcz added a comment. Looks good to me overall, some minor style comments included ;-) Do we expect this to be a generic model code generator that gets reused for other things? If not, maybe we can hardcode more (like the namespace, class name, etc), but if you think there's other use cases f

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 291909. usaxena95 added a comment. Fixed namespace ending. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files: clang-tools-extra/clangd/CMakeLists.txt clang-to

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 291813. usaxena95 added a comment. Fixed namespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-ext

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/unittests/DecisionForestTests.cpp:5 + +namespace clangd { +namespace clangd { This is supposed to be "namespace clang", right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 291205. usaxena95 added a comment. Added README.md for the code completion model. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files: clang-tools-extra/clangd/CM

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 added a comment. Hi @jkorous > Do you guys intend to open-source also the training part of the model > pipeline ? Open sourcing the training part (both dataset generation and using an open sourced DecisionForest based framework for training) has been on our radar. Although gathering

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:30 + +set(DF_COMPILER ${CMAKE_CURRENT_SOURCE_DIR}/CompletionModelCodegen.py) +include(${CMAKE_CURRENT_SOURCE_DIR}/CompletionModel.cmake) sammccall wrote: > if you want the comp

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 291024. usaxena95 marked 23 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files: clang-too

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

jkorous added subscribers: dexonsmith, akyrtzi. jkorous added a comment. Hi @usaxena95 and @sammccall, I am wondering about couple high-level things. Do you guys intend to open-source also the training part of the model pipeline or publish a model trained on generic-enough training set so it co

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

sammccall added a comment. In D83814#2166349 , @usaxena95 wrote: > This is still WIP and I will provide more details in the description once > this is finalized. This really should have high level documentation - I don't think Nathan will be the only o

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 280455. usaxena95 edited the summary of this revision. usaxena95 added a comment. Better formatting in generated files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 280406. usaxena95 added a comment. Addressed offline comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files: clang-tools-extra/clangd/CMakeLists.txt clan

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 added a comment. The features refers to the code completion signals in https://github.com/llvm/llvm-project/blob/master/clang-tools-extra/clangd/Quality.h These signals are currently used to map the code completion candidates to a relevance score using hand-coded heuristics. We intend

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

nridge added a comment. Is there some additional context for what this patch is aiming to do? The description sounds interesting but I don't really understand it. What is a "feature" in this context? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. [WIP] - Proposes a json format for representing Random Forest model. - Proposes a way to test the generated runtime using a test mod