[PATCH] D83759: [clangd] Fixes in lit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG98b56c09be00: [clangd] Fixes in lit tests (authored by ArcsinX). Changed prior to commit: https://reviews.llvm.org/D83759?vs=279781&id=279789#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D83759: [clangd] Fixes in lit tests

kadircet accepted this revision. kadircet added a comment. thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83759/new/ https://reviews.llvm.org/D83759 ___ cfe-commits mailing list cfe-commit

[PATCH] D83759: [clangd] Fixes in lit tests

ArcsinX marked an inline comment as done. ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/test/background-index.test:6 +# RUN: sed -e "s|DIRECTORY|%/t|" %/t/definition.jsonrpc > %/t/definition.jsonrpc.1 +# RUN: sed -i.bak -e "s|DIRECTORY|%/t|" %/t/compile_com

[PATCH] D83759: [clangd] Fixes in lit tests

ArcsinX updated this revision to Diff 279781. ArcsinX added a comment. Get rid of `-i` `sed` option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83759/new/ https://reviews.llvm.org/D83759 Files: clang-tools-extra/clangd/test/Inputs/background-i

[PATCH] D83759: [clangd] Fixes in lit tests

kadircet added inline comments. Comment at: clang-tools-extra/clangd/test/background-index.test:6 +# RUN: sed -e "s|DIRECTORY|%/t|" %/t/definition.jsonrpc > %/t/definition.jsonrpc.1 +# RUN: sed -i.bak -e "s|DIRECTORY|%/t|" %/t/compile_commands.json +# On Windows, we need the URI

[PATCH] D83759: [clangd] Fixes in lit tests

ArcsinX marked an inline comment as done. ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/test/background-index.test:6 +# RUN: sed -e "s|DIRECTORY|%/t|" %/t/definition.jsonrpc > %/t/definition.jsonrpc.1 +# RUN: sed -i.bak -e "s|DIRECTORY|%/t|" %/t/compile_com

[PATCH] D83759: [clangd] Fixes in lit tests

kadircet added inline comments. Comment at: clang-tools-extra/clangd/test/background-index.test:6 +# RUN: sed -e "s|DIRECTORY|%/t|" %/t/definition.jsonrpc > %/t/definition.jsonrpc.1 +# RUN: sed -i.bak -e "s|DIRECTORY|%/t|" %/t/compile_commands.json +# On Windows, we need the URI

[PATCH] D83759: [clangd] Fixes in lit tests

ArcsinX added a comment. I believe it's okay now on macOS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83759/new/ https://reviews.llvm.org/D83759 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D83759: [clangd] Fixes in lit tests

ArcsinX updated this revision to Diff 279754. ArcsinX added a comment. [macOS] Fix `background-index.test` failure, don't create `*-e` files during `background-index.test` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83759/new/ https://reviews.ll

[PATCH] D83759: [clangd] Fixes in lit tests

kadircet added a comment. In D83759#2165974 , @ArcsinX wrote: > Seem the problem is in `-i` option. > According with OSX man: > `sed [-Ealn] command [file ... ]` > `sed [-Ealn] [-e command] [-f command_file] [-i extension] [file ...]`. > > Seems on macO

[PATCH] D83759: [clangd] Fixes in lit tests

ArcsinX added a comment. Seem the problem is in `-i` option. According with OSX man: `sed [-Ealn] command [file ... ]` `sed [-Ealn] [-e command] [-f command_file] [-i extension] [file ...]`. Seems on macOS `-E` is treated as an argument for `-i` in command like `sed -i -E -e ...` . Also, seems

[PATCH] D83759: [clangd] Fixes in lit tests

ArcsinX added a comment. In D83759#2165116 , @thakis wrote: > Looks like this breaks tests on macOS (and probably with non-gnu greps): > http://45.33.8.238/mac/17611/step_9.txt > > Please take a look, and revert while you investigate if it takes a while t

[PATCH] D83759: [clangd] Fixes in lit tests

thakis added a comment. Looks like this breaks tests on macOS (and probably with non-gnu greps): http://45.33.8.238/mac/17611/step_9.txt Please take a look, and revert while you investigate if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D83759: [clangd] Fixes in lit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGff63d6be93dc: [clangd] Fixes in lit tests (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83759/new/ https://reviews.llvm.org/D83759 F

[PATCH] D83759: [clangd] Fixes in lit tests

ArcsinX added a comment. In D83759#2164296 , @kadircet wrote: > as i mentioned please watch out for buildbot breakages after landing this. > (and again let me know if I should land this for you) Thanks for review. Yes, could you please land this for me

[PATCH] D83759: [clangd] Fixes in lit tests

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! as i mentioned please watch out for buildbot breakages after landing this. (and again let me know if I should land this for you) Repository: rG LLVM Github Monorepo CHAN