This revision was automatically updated to reflect the committed changes.
Closed by commit rG92fa91bb4029: [OpenCL] Fixed missing address space for
templated copy constructor. (authored by Anastasia).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D836
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83665/new/
https://reviews.llvm.org/D83665
___
cfe-commits mailing list
olestrohm updated this revision to Diff 279485.
olestrohm added a comment.
The code now directly adds the __generic address space to the pointee type.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83665/new/
https://reviews.llvm.org/D83665
Files:
clang/lib/Sema/SemaTemplateDeduction.
Anastasia added inline comments.
Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3811
+ if(S.getLangOpts().OpenCL)
+ArgType = S.deduceOpenCLPointeeAddrSpace(ArgType);
ArgType = S.Context.getLValueReferenceType(ArgType);
olestrohm wrote:
>
olestrohm marked an inline comment as done.
olestrohm added inline comments.
Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3811
+ if(S.getLangOpts().OpenCL)
+ArgType = S.deduceOpenCLPointeeAddrSpace(ArgType);
ArgType = S.Context.getLValueReferenceType(A
Anastasia added inline comments.
Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3811
+ if(S.getLangOpts().OpenCL)
+ArgType = S.deduceOpenCLPointeeAddrSpace(ArgType);
ArgType = S.Context.getLValueReferenceType(ArgType);
I feel we can just
olestrohm created this revision.
olestrohm added reviewers: Anastasia, rjmccall.
olestrohm added a project: clang.
Herald added subscribers: cfe-commits, yaxunl.
When you have a templated constructor with an R-value reference the compiler
implicitly creates a copy and move constructor through the
