[PATCH] D83591: [OpenMP][CUDA] Fix std::complex in GPU regions

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5667d00e044: [OpenMP][CUDA] Fix std::complex in GPU regions (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83591/new/ https://revie

[PATCH] D83591: [OpenMP][CUDA] Fix std::complex in GPU regions

jdoerfert added a comment. Thx for the reviews! FWIW, OpenMP should be able to use the C/C++ standard functions/macros for this eventually. Getting the overloads right if you don't have type system support is tricky though and I need more time... On a separate note, we should bundle the resour

[PATCH] D83591: [OpenMP][CUDA] Fix std::complex in GPU regions

yaxunl accepted this revision. yaxunl added a comment. LGTM. This fixed the regression caused by previous change. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83591/new/ https://reviews.llvm.org/D83591 __

[PATCH] D83591: [OpenMP][CUDA] Fix std::complex in GPU regions

tra accepted this revision. tra added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83591/new/ https://reviews.llvm.org/D83591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D83591: [OpenMP][CUDA] Fix std::complex in GPU regions

tra added a comment. In D83591#2145512 , @JonChesterfield wrote: > In D83591#2145437 , @jdoerfert wrote: > > > I did not know they are using __clang_cuda headers. (Site note, we should > > rename them then.) > > >

[PATCH] D83591: [OpenMP][CUDA] Fix std::complex in GPU regions

JonChesterfield added a comment. In D83591#2145437 , @jdoerfert wrote: > I did not know they are using __clang_cuda headers. (Site note, we should > rename them then.) I also did not know that. I am repeatedly caught out by things named 'cuda', 'nvptx'

[PATCH] D83591: [OpenMP][CUDA] Fix std::complex in GPU regions

jdoerfert updated this revision to Diff 277173. jdoerfert added a comment. Keep the std:: functions in non-OpenMP mode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83591/new/ https://reviews.llvm.org/D83591 Files: clang/lib/Headers/__clang_cuda

[PATCH] D83591: [OpenMP][CUDA] Fix std::complex in GPU regions

jdoerfert added a comment. In D83591#2145411 , @tra wrote: > In D83591#2145378 , @JonChesterfield > wrote: > > > Fine by me. Let's get nvptx working properly in tree now and work out how > > to wire up amdgcn subs

[PATCH] D83591: [OpenMP][CUDA] Fix std::complex in GPU regions

tra added a comment. In D83591#2145378 , @JonChesterfield wrote: > Fine by me. Let's get nvptx working properly in tree now and work out how to > wire up amdgcn subsequently. I'm sure a reasonable abstraction will present > itself. I'm missing somethi

[PATCH] D83591: [OpenMP][CUDA] Fix std::complex in GPU regions

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Fine by me. Let's get nvptx working properly in tree now and work out how to wire up amdgcn subsequently. I'm sure a reasonable abstraction will present itself. Repository:

[PATCH] D83591: [OpenMP][CUDA] Fix std::complex in GPU regions

jdoerfert created this revision. jdoerfert added reviewers: tra, hfinkel, JonChesterfield. Herald added subscribers: sstefan1, guansong, bollu, yaxunl. Herald added a project: clang. The old way worked to some degree for C++-mode but in C mode we actually tried to introduce variants of macros (e.g