[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

2020-07-15 Thread David Spickett via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. DavidSpickett marked an inline comment as done. Closed by commit rGfe5912249efa: [clang][Driver] Fix tool path priority test failures (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

2020-07-14 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. I have reproduced the type 1 failure and I confirm that this patch fixes the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/ https://reviews.llvm.org/D83055 ___

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

2020-07-13 Thread Steven Wan via Phabricator via cfe-commits
stevewan accepted this revision. stevewan added a comment. This revision is now accepted and ready to land. This LGTM, but since I'm not most familiar with the type 1 failure in description, let's see if other reviewers have further comments. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

2020-07-13 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: clang/test/Driver/program-path-priority.c:117 +/// Check file exists first in case $DEFAULT_TRIPLE == %target_triple +// RUN: file -E %t/$DEFAULT_TRIPLE-gcc 2>&1 > /dev/null && \ +//

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

2020-07-13 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 277344. DavidSpickett marked an inline comment as done. DavidSpickett added a comment. - Use more standard 'test -f' command before 'mv's Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/ https://r

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

2020-07-10 Thread Steven Wan via Phabricator via cfe-commits
stevewan added inline comments. Comment at: clang/test/Driver/program-path-priority.c:117 +/// Check file exists first in case $DEFAULT_TRIPLE == %target_triple +// RUN: file -E %t/$DEFAULT_TRIPLE-gcc 2>&1 > /dev/null && \ +// RUN: mv %t/$DEFAULT_TRIPLE-gcc %t/prefix || true -

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

2020-07-10 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: clang/test/Driver/program-path-priority.c:117 +/// Check file exists first in case $DEFAULT_TRIPLE == %target_triple +// RUN: file -E %t/$DEFAULT_TRIPLE-gcc 2>&1 > /dev/null && \ +//

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

2020-07-10 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 276952. DavidSpickett added a comment. - mv with stderr redirected instead of using non standard file -E flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/ https://reviews.llvm.org/D83055 File

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

2020-07-09 Thread Steven Wan via Phabricator via cfe-commits
stevewan added inline comments. Comment at: clang/test/Driver/program-path-priority.c:117 +/// Check file exists first in case $DEFAULT_TRIPLE == %target_triple +// RUN: file -E %t/$DEFAULT_TRIPLE-gcc 2>&1 > /dev/null && \ +// RUN: mv %t/$DEFAULT_TRIPLE-gcc %t/prefix || true -

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

2020-07-09 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 276671. DavidSpickett added a comment. - Updated rm/mv command lines to account for $DEFAULT_TRIPLE being the same as %target_triple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/ https://revi

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

2020-07-08 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/Driver/program-path-priority.c:117 // RUN: mv %t/$DEFAULT_TRIPLE-gcc %t/prefix +// RUN: mv %t/%target_triple-gcc %t/prefix // RUN: touch %t/notreal-none-elf-gcc && chmod +x %t/notreal-none-elf-gcc If $DEFAUL

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

2020-07-08 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added a comment. For the record my logic here is that I could change the tool names to use the same name as --version. However that will break whatever mips toolchain needed this code in the first place. (https://reviews.llvm.org/D13340?id=36227#inline-108606) This default triple